Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Your Experience With PWA Kit - Fall 2023 #1542

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Nov 16, 2023

Backport of #1502 to v2, primarily so that the survey appears on the npm page for the v2 packages.

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@wjhsf wjhsf requested a review from a team as a code owner November 16, 2023 17:44
@wjhsf wjhsf changed the base branch from develop to release-2.8.x November 17, 2023 16:12
@wjhsf wjhsf enabled auto-merge (squash) November 20, 2023 17:08
@wjhsf wjhsf closed this Nov 21, 2023
auto-merge was automatically disabled November 21, 2023 01:34

Pull request was closed

@wjhsf wjhsf reopened this Nov 21, 2023
@wjhsf wjhsf enabled auto-merge (squash) November 21, 2023 01:34
@wjhsf wjhsf merged commit 9092f4a into release-2.8.x Nov 29, 2023
29 checks passed
@wjhsf wjhsf deleted the add-survey-to-v2-READMEs branch November 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants