W-14337993: Fix a11y for tab focus, implement gift option for basket #1546
Conversation
| @@ -56,25 +56,25 @@ const PromoPopover = ({header, children, ...props}) => { | |||
| })} | |||
| /> | |||
| </PopoverTrigger> | |||
| <Portal> | |||
There was a problem hiding this comment.
Portal makes the PopoverContent not focusable
| <Box boxShadow="lg"> | ||
| <PopoverArrow /> | ||
| <PopoverCloseButton /> | ||
| <PopoverHeader borderBottom="none" tabindex="0"> |
There was a problem hiding this comment.
adding tabIndex here to make the screen reader recognize and read the content. Without it, it will ignore, and only close button is focusable with keyboard
| /> | ||
| </Button> | ||
| </Box> | ||
| {/* Uncomment if you want to provide a link to your gift site*/} |
There was a problem hiding this comment.
Since we don't have link for this button, let comment it out from here to avoid a11y issue. Developer can use it when they see fit.
There was a problem hiding this comment.
Why comment out this code but delete the translation? Do we want to take a consistent action here, either delete both, or comment out both? If you choose to comment out both, you'll have to update your comment above to indicate that they can also go uncomment out the translation.
There was a problem hiding this comment.
Translations are usually automatically generated, it does not make sense to comment it there, but we can add a note here to tell dev to re-build translation if they choose to uncomment out this section.
packages/template-retail-react-app/app/components/promo-popover/index.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/components/promo-popover/index.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/cart/partials/cart-secondary-button-group.jsx
Show resolved
Hide resolved
…le-by-keyboard' into W-14337993/a11y-fix-funcs-operable-by-keyboard
…le-by-keyboard' into W-14337993/a11y-fix-funcs-operable-by-keyboard
Description
This PR fixes a11y issues in https://gus.lightning.force.com/a07EE00001cqESEYA2
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization