-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix focus indicator for hero features. #1561
Conversation
Signed-off-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you'll have to resolve the CHANGELOG.md
conflict, I'll give you another approval once that gets fixed
Signed-off-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Signed-off-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
<Box | ||
background={'white'} | ||
boxShadow="0px 2px 2px rgba(0, 0, 0, 0.1)" | ||
borderRadius={'4px'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should have made this clear for all lines here. I thought you would have noticed. 😅
borderRadius={'4px'} | |
background='white' | |
borderRadius='4px' |
Before:
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization