-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-12627096@ Translate en-US and en-GB by default #1574
Conversation
|
||
try { | ||
// example usage: node ./scripts/translations/extract-default-messages en-US en-GB | ||
process.argv.slice(2).forEach(extract) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wjhsf is this opt-in? E.g. can a customer opt out of the behavior if it's not desired? I see in the package.json change that we are explicit about <command> en-US en-GB
so that implies "yes" to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The customer can specify whatever locales they choose, if that's what you're asking about.
Signed-off-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming it's opt-in (I believe it is from reading the code), LGTM
Description
With all of the small changes lately, remembering to extract to en-GB is annoying, when the script only does en-US by default. It's a trivial change to fix it, so I fixed it.
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization