-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[馃悶Bug] - Fix <ProductItem />
Not Being Overridable
#1672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<ProductItem />
Overridability <ProductItem />
Not Being Overridable
alexvuong
previously approved these changes
Feb 20, 2024
kevinxh
previously approved these changes
Feb 21, 2024
@@ -16,7 +16,7 @@ import {useWishList} from '@salesforce/retail-react-app/app/hooks/use-wish-list' | |||
|
|||
import PageActionPlaceHolder from '@salesforce/retail-react-app/app/components/page-action-placeholder' | |||
import {HeartIcon} from '@salesforce/retail-react-app/app/components/icons' | |||
import ProductItem from '@salesforce/retail-react-app/app/components/product-item/index' | |||
import ProductItem from '@salesforce/retail-react-app/app/components/product-item' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL! you can't have index in your import path, is there a bug with the webpack extensibility plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is yes, ticket incoming
Signed-off-by: Ben Chypak <bchypak@mobify.com>
alexvuong
approved these changes
Feb 21, 2024
kevinxh
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1657
Looks like we were importing the ProductItem component in a valid syntax but not compatible with overrides. Lets fix these imports and then we can work on fixing the support for these types of imports later.
Types of Changes
Changes
/index
from imports of the product-item component in the template.How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization