Remove _sfdc_customer_id

[kevinxh]

Description

With the recent MRT HTTP3 upgrade, headers that starts with _ is no longer accepted and will cause errors.

Types of Changes

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Breaking change (could cause existing functionality to not work as expected)
• Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

• Removing a public function or component or prop
• Adding a required argument to a function
• Changing the data type of a function parameter or return value
• Adding a new peer dependency to package.json

Changes

• remove _sfdc_customer_id

How to Test-Drive This PR

• (step1)

Checklists

General

• Changes are covered by test cases
• CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

• There are no changes to UI

or...

• Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
• Changes comply with WCAG 2.0 guidelines levels A and AA
• Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

• Changes include a UI text update in the Retail React App (which requires translation)

[vcua-mobify]

Going to approve as this change is small.
From my understanding, the _sfdc_customer_id is no longer required as it is internally set by SCAPI.

[vmarta]

Let's mention the http3 upgrade to be clearer. Otherwise, without context, it may confuse customer why this header is no longer valid.

[vmarta]

We'll need to do the same thing to the older PWA Kit: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/release-2.6.x/packages/template-retail-react-app/app/commerce-api/hooks/useBasket.js#L367-L374

[kevinxh]

No net new customer should use v2 and existing customers will need to patch their project, therefore i don't think we need to patch v2 pwa kit?

[vmarta]

I see 🤔 good point, all right we don't need to patch v2.

[vmarta]

I see 🤔 good point, all right we don't need to patch v2.

[adamraya]

We probably also want to align and remove references to the _sfdc_client_auth header.

pwa-kit/packages/commerce-sdk-react/src/hooks/ShopperLogin/mutation.ts

Lines 61 to 68 in 8ef8ae3

	* Get a shopper JWT access token for a registered customer using a trusted agent (merchant).
	If using a SLAS private client ID, you must also use an `_sfdc_client_auth` header.
	The value of the `_sfdc_client_auth` header must be a Base64-encoded string. The string is composed of a SLAS private client ID and client secret, separated by a colon (`:`). For example, `privateClientId:privateClientsecret` becomes `cHJpdmF0ZUNsaWVudElkOnByaXZhdGVDbGllbnRzZWNyZXQ=` after Base64 encoding.
	* @returns A TanStack Query mutation hook for interacting with the Shopper Login `getTrustedAgentAccessToken` endpoint.
	*/
	GetTrustedAgentAccessToken: 'getTrustedAgentAccessToken',