Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PWA Kit 2.8.3 #1741

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Release PWA Kit 2.8.3 #1741

merged 3 commits into from
Apr 18, 2024

Conversation

vmarta
Copy link
Contributor

@vmarta vmarta commented Apr 9, 2024

2.8.3 would include these fixes:

  • upgrading the express dependency
  • and avoiding stale SCAPI responses when on Storefront Preview

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Bumped up the version number
  • Updated the changelog files accordingly

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@vmarta vmarta requested a review from a team as a code owner April 9, 2024 23:10
Copy link
Contributor

@vcua-mobify vcua-mobify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw only the version bumps so I was wondering where the fixes were. I see they are already merged into the branch and that we are just bumping the package.json number to trigger the release job.

Approving

@kevinxh kevinxh merged commit 443f9fb into release-2.8.x Apr 18, 2024
29 checks passed
@kevinxh kevinxh deleted the 2.8.3 branch April 18, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants