Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fav icon multi click Issue ##1490 #1742

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix fav icon multi click Issue ##1490 #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 32 additions & 40 deletions packages/template-retail-react-app/app/components/product-tile/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/

import React, {useRef} from 'react'
import React, {useState} from 'react'
import PropTypes from 'prop-types'
import {HeartIcon, HeartSolidIcon} from '@salesforce/retail-react-app/app/components/icons'

Expand All @@ -29,6 +29,7 @@ import {productUrlBuilder} from '@salesforce/retail-react-app/app/utils/url'
import Link from '@salesforce/retail-react-app/app/components/link'
import withRegistration from '@salesforce/retail-react-app/app/components/with-registration'
import {useCurrency} from '@salesforce/retail-react-app/app/hooks'
import debounce from 'lodash/debounce'

const IconButtonWithRegistration = withRegistration(IconButton)

Expand Down Expand Up @@ -75,8 +76,13 @@ const ProductTile = (props) => {
const localizedProductName = product.name ?? product.productName

const {currency: activeCurrency} = useCurrency()
const isFavouriteLoading = useRef(false)
const [isFavouriteLoading, setFavouriteLoading] = useState(false)
const styles = useMultiStyleConfig('ProductTile')
const debounceToggleFav = debounce(async (e) => {
setFavouriteLoading(true)
await onFavouriteToggle(!isFavourite)
setFavouriteLoading(false)
}, 500)

return (
<Box {...styles.container}>
Expand Down Expand Up @@ -126,44 +132,30 @@ const ProductTile = (props) => {
</Text>
</Link>
{enableFavourite && (
<Box
onClick={(e) => {
// stop click event from bubbling
// to avoid user from clicking the underlying
// product while the favourite icon is disabled
e.preventDefault()
}}
>
<IconButtonWithRegistration
data-testid="wishlist-button"
aria-label={
isFavourite
? intl.formatMessage(
{
id: 'product_tile.assistive_msg.remove_from_wishlist',
defaultMessage: 'Remove {product} from wishlist'
},
{product: localizedProductName}
)
: intl.formatMessage(
{
id: 'product_tile.assistive_msg.add_to_wishlist',
defaultMessage: 'Add {product} to wishlist'
},
{product: localizedProductName}
)
}
icon={isFavourite ? <HeartSolidIcon /> : <HeartIcon />}
{...styles.favIcon}
onClick={async () => {
if (!isFavouriteLoading.current) {
isFavouriteLoading.current = true
await onFavouriteToggle(!isFavourite)
isFavouriteLoading.current = false
}
}}
/>
</Box>
<IconButtonWithRegistration
data-testid="wishlist-button"
aria-label={
isFavourite
? intl.formatMessage(
{
id: 'product_tile.assistive_msg.remove_from_wishlist',
defaultMessage: 'Remove {product} from wishlist'
},
{product: localizedProductName}
)
: intl.formatMessage(
{
id: 'product_tile.assistive_msg.add_to_wishlist',
defaultMessage: 'Add {product} to wishlist'
},
{product: localizedProductName}
)
}
disabled={isFavouriteLoading}
icon={isFavourite ? <HeartSolidIcon /> : <HeartIcon />}
{...styles.favIcon}
onClick={debounceToggleFav}
/>
)}
</Box>
)
Expand Down
2 changes: 1 addition & 1 deletion packages/template-retail-react-app/app/components/with-registration/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const withRegistration = (
authModal.onOpen()
}
} else {
onClick()
onClick(e)
}
}

Expand Down
Loading