-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-15654904Showing strikethrough price on PLP #1760
Merged
Merged
Changes from 11 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
f66b61a
strikethrough for PLP
alexvuong 50b3bce
add param for getProducts in useEinstein
alexvuong 249785e
PR feedback
alexvuong ceddadf
Refactoring getDisplayPrice
alexvuong 56f0736
remove unused variables
alexvuong ae1da47
remove unvalid param
alexvuong 5fc66c8
take closest tiered price into account
alexvuong b2bbabb
fix test
alexvuong 87399dc
put back recommendation section
alexvuong 4672407
changing label
alexvuong 2ae213c
fix bundle size
alexvuong 67892d7
fix tierPrices filter logic
alexvuong 74df5ab
fix tierPrices filter logic
alexvuong 3c62c54
fix tierPrices filter logic
alexvuong 5025ed2
fix tierPrices filter logic
alexvuong 1753373
fix lint
alexvuong 913110c
add more cases for display price util
alexvuong 5392f7e
add more cases for display price util
alexvuong 809ca51
fix logic in getDisplayPrice
alexvuong 90bd3d0
PR feedback
alexvuong 906b521
PR feedback
alexvuong 7a36794
fix tests
alexvuong 87fbc8b
Apply formattedmessage to display price, refactor price info logic in…
alexvuong cf31976
remove console
alexvuong 2afea83
guard the values
alexvuong 165c2db
fix tests
alexvuong cf51887
adjust price display
alexvuong 7600f95
fix tests
alexvuong e4cf009
replace formatted string with jsx logic
alexvuong 04a4ce8
fix tests naming
alexvuong 9045fa4
fiz translations
alexvuong 9f2150f
Pr feedback
alexvuong 47552a7
fix template
alexvuong 9882e1a
tweak proptype
alexvuong 06f8202
let bold font for PLP
alexvuong 063a7f5
optimizing display price logic
alexvuong 59b33ab
edit jsx
alexvuong 8dac001
PR feedback
alexvuong 5137079
lint
alexvuong c866572
fix test
alexvuong 8dc7e96
build translations
alexvuong d5c94ff
PR feedback
alexvuong 5a9a04a
separate pricing components into its own files
alexvuong e43dccb
lint
alexvuong f872153
fix flaky test
alexvuong File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed unused variable