W-15784798 - Finalize Lazy Navigation Changes #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nothing had to be done in this PR except for removing a comment about finalizing the solution when the API is updated. It looks like I had preemptively get the
itemsCountKeyto the new return value ofonlineSubCategoriesCountso that once the API was released, it would just work, which it does. Below is a screen shot of the before and after of the API being updated. You can notice that menu items (like earrings) that don't have children were rendering a sub-menu ("shop all") when they aren't required to.Before:
After:
Types of Changes
Changes
How to Test-Drive This PR