Sandbox inject settings #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs and webdav permissions to created sandbox
astound-ci
approved these changes
Apr 2, 2020
astound-ci
reviewed
Apr 3, 2020
There was a problem hiding this comment.
@tobiaslohr in case we pass same client_id would be nice not to break with an error but perform smart merge (not overwrite existing but extend, add only missing resources) and proceed. Thanks
…based on user feedback
|
@astound-ci thanks for the feedback, I've made some modifications as part of this PR, please review |
|
@tobiaslohr worked like a charm, thanks. Waiting for a release as soon as possible to implement cool new monitoring feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124