Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Strict Mode #34

Closed
stash-sfdc opened this issue Apr 24, 2015 · 1 comment
Closed

Remove Strict Mode #34

stash-sfdc opened this issue Apr 24, 2015 · 1 comment
Milestone
1.0 API Changes

Comments

@stash-sfdc
Copy link
Contributor

Via @inikulin:

The thing that bothers me most is the strict mode. If enabled it doesn't pass IETF's tests, therefore currently non-strict mode is stricter than "strict" mode. So, I suggest to get rid of "strict" mode. I can issue a PR if you are OK with it.

In the interest of simplicity and compliance, we should remove this mode prior to 1.0. This means an API breaking change, so let's maintain it on a "1.0-pre" branch in case we need to apply fixes to 0.x (currently 0.13)
@stash-sfdc stash-sfdc added this to the 1.0 API Changes milestone Apr 24, 2015
@stash-sfdc stash-sfdc mentioned this issue Apr 24, 2015
Closed
@inikulin inikulin reopened this Apr 27, 2015
@inikulin
Copy link
Contributor

Forgot to switch remotes at first, sorry for that. Reverted and issued as pull request.

stash-sfdc added a commit that referenced this issue Apr 28, 2015
@stash-sfdc
Merge pull request #37 from inikulin/master
246a09f 
Get rid of strict mode (closes #34, fixes #9)
wjhsf pushed a commit that referenced this issue Feb 8, 2024
ensure run with NODE_ENV set to test (#34)
1326a73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 API Changes
Development

No branches or pull requests
2 participants
@inikulin @stash-sfdc