Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp options for generate_apex_docs task #601

Merged
merged 6 commits into from Apr 18, 2018
Merged

Revamp options for generate_apex_docs task #601

merged 6 commits into from Apr 18, 2018

Conversation

cpolcyn
Copy link
Contributor

@cpolcyn cpolcyn commented Apr 13, 2018

Closes #377

@cpolcyn cpolcyn requested a review from cdcarter April 13, 2018 17:43
cdcarter
cdcarter previously approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@cdcarter cdcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@jlantz - is there a reason we made these apexdoc bits actual project config keys instead of task config? i think we might want to open a ticket to move these (and many other opts) to task config.

@cpolcyn
Copy link
Contributor Author

cpolcyn commented Apr 13, 2018

@cdcarter I think I did the original work actually. I'm not against moving things to task config but I do like having defaults, especially for branch and scope.

@cpolcyn cpolcyn changed the title Make header and homepage args optional for ApexDoc Revamp options for generate_apex_docs task Apr 13, 2018
@cpolcyn
Copy link
Contributor Author

cpolcyn commented Apr 13, 2018

@cdcarter I brought everything into task options as suggested. Please re-review.

@cpolcyn cpolcyn merged commit 2bcc398 into master Apr 18, 2018
@cpolcyn cpolcyn deleted the feature/apexdoc-args branch April 18, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdcarter cdcarter cdcarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpolcyn @cdcarter