Update Elevate Recurring Gifts When Info Is Updated in Batch Gift Entry #7132
Conversation
…alesforceFoundation/NPSP into feature/242__rd2BatchUpdateBGE
…alesforceFoundation/NPSP into feature/242__rd2BatchUpdateBGE
…s read-only and editable
|
We are still waiting on a label approval from @ErinWiedemer in this one |
There was a problem hiding this comment.
Looks good, @daniel-fuller. I appreciate the fact that you always improve what you touch!
|
@daniel-fuller Stephen Cox is reviewing the error message now and I hope that we'll have an approval tomorrow. Right now, he's leaning toward the following text for the error message: You can’t edit this Elevate-connected gift until you re-enter the payment information. Select Edit Payment Information. I'll let you know as soon as I get confirmation from CCX. |
There was a problem hiding this comment.
Looks good @daniel-fuller , I just have a comment about when we null the fields
| <language>en_US</language> | ||
| <protected>true</protected> | ||
| <shortDescription>Warns users to re-enter payment information when editing Elevate-connected gifts</shortDescription> | ||
| <value>You can’t edit this Elevate-connected gift until you re-enter the payment information. Select Edit Payment Information.</value> |
There was a problem hiding this comment.
Nitpick, but I like to avoid apostrophes in Custom Labels (especially this weird rich-text version!)
| import PAYMENT_ELEVATE_ELEVATE_BATCH_ID from '@salesforce/schema/DataImport__c.Payment_Elevate_Batch_Id__c'; | ||
| import GeGatewaySettings from 'c/geGatewaySettings'; | ||
| import Gift from 'c/geGift'; |
There was a problem hiding this comment.
I think we removed one unused import, then added another?
| @@ -12,6 +31,93 @@ describe('ge-gift', () => { | |||
| jest.clearAllMocks(); | |||
| }); | |||
|
|
|||
| it ('removable elevate status should return false for imported status', async () => { | |||
| this.getFieldValue(PAYMENT_STATUS.fieldApiName) === PAYMENT_STATUSES.AUTHORIZED || | ||
| this.getFieldValue(PAYMENT_STATUS.fieldApiName) === PAYMENT_STATUSES.PENDING | ||
| ) || | ||
| this.hasCommitmentId(); |
There was a problem hiding this comment.
Wouldn't this last condition allow an imported RD to be removed from the Batch, and is that ok? I only ask because we explicitly check for a Status of not Imported in the first condition.
There was a problem hiding this comment.
@lparrott You're right. Technically, I don't think it would be a problem since it's already been processed at that point and the Update button is disabled for Imported but I updated the parentheses to be more accurate
…into feature/242__rd2BatchUpdateBGE
…into feature/242__rd2BatchUpdateBGE
This work allows a user to switch between a recurring and one-time Elevate-connected gift in batch gift entry before processing the gift in the batch.
W-11871096
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata