-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/242 gateway assignment tests #7152
Feature/242 gateway assignment tests #7152
Conversation
…lesforceFoundation/NPSP into feature/242__gateway-assignment-tests
Tracking W-11793517 |
…lesforceFoundation/NPSP into feature/242__gateway-assignment-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just had a few non-blocking questions.
expect(getCCCheckBox(element)).toBeTruthy(); | ||
}) | ||
|
||
it("does not display gateways and payment methods when collapsed", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the test above could probably be the same test, just need to add the expectations after it's expanded 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had initially combined the tests, but thought it might be more clear what was being tested if they were separate. I'll put them back together.
document.body.appendChild(element); | ||
await flushPromises(); | ||
|
||
expect(element).toBeTruthy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this testing? Isn't Gateway Management Mode for the NPSP Settings page? The template has nothing to do with that, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can eliminate the test if that seems right. What it is testing is to make sure that gateway management isn't affected by that setting. It should always be null, so seems fine to cut it out.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata