Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/242 gateway assignment tests #7152

Merged
merged 10 commits into from
Nov 15, 2022

Conversation

npsp-reedestockton
Copy link
Contributor

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

@npsp-reedestockton
Copy link
Contributor Author

Tracking W-11793517

Copy link
Contributor

@daniel-fuller daniel-fuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@lparrott lparrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just had a few non-blocking questions.

expect(getCCCheckBox(element)).toBeTruthy();
})

it("does not display gateways and payment methods when collapsed", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the test above could probably be the same test, just need to add the expectations after it's expanded 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had initially combined the tests, but thought it might be more clear what was being tested if they were separate. I'll put them back together.

document.body.appendChild(element);
await flushPromises();

expect(element).toBeTruthy();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this testing? Isn't Gateway Management Mode for the NPSP Settings page? The template has nothing to do with that, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can eliminate the test if that seems right. What it is testing is to make sure that gateway management isn't affected by that setting. It should always be null, so seems fine to cut it out.

@daniel-fuller daniel-fuller merged commit 15858f0 into feature/242 Nov 15, 2022
@daniel-fuller daniel-fuller deleted the feature/242__gateway-assignment-tests branch November 15, 2022 17:48
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants