Merge main into feature/fix_q3_robot

.github/ISSUE_TEMPLATE/read-this-for-all-support-and-questions.md

@@ -0,0 +1,15 @@
+---
+name: READ THIS FOR ALL SUPPORT AND QUESTIONS
+about: 'GO HERE: http://sfdc.co/npchub'
+title: ''
+labels: invalid
+assignees: ''
+
+---
+
+==== IMPORTANT NOTES ====
+
+The Nonprofit Success Pack team does not review or respond to support requests or questions posted in this repository.
+
+Instead, please post all questions and issues directly in the Nonprofit Hub of the Trailblazer Community: http://sfdc.co/npchub
+========================================================================

README.md

@@ -1,20 +1,36 @@
 ![Salesforce Nonprofit Success Pack](https://cloud.githubusercontent.com/assets/450473/18836784/15e1774a-83c7-11e6-8434-0521d4fbebc0.png "Salesforce Nonprofit Success Pack")
 
-#### For Users
+## Important Note
 
-* <a href="https://trailhead.salesforce.com/trailblazer-community/groups/0F94S000000kHitSAE?tab=discussion&sort=LAST_MODIFIED_DATE_DESC" target="_blank">Ask questions or get help</a>
-* <a href="https://github.com/SalesforceFoundation/NPSP/issues/new" target="_blank">Log a confirmed Issue</a> or <a href="https://ideas.salesforce.com/s/search#t=All&sort=relevancy" target="_blank">Feature Request</a>
-* <a href="https://help.salesforce.com/s/articleView?id=sfdo.Nonprofit_Success_Pack.htm&type=5" target="_blank">Nonprofit Success Pack (NPSP) Documentation</a>
-* Check out existing <a href="https://github.com/SalesforceFoundation/NPSP/labels/bug" target="_blank">bugs</a> and <a href="https://ideas.salesforce.com/s/search#t=All&sort=relevancy&f:@sfcategoryfull=[Nonprofit%7CNonprofit%20Success%20Pack]" target="_blank">feature and enhancement requests.</a>
-* <a href="https://github.com/SalesforceFoundation/NPSP/releases" target="_blank">Release Notes and Beta Releases</a>
+In 2023, Salesforce launched the Nonprofit Cloud which is at the foundation of Salesforce for Nonprofits. Nonprofit Cloud helps teams unify their data to work beyond silos and better collaborate, share, learn from, and use their data. Use Nonprofit Cloud as your a single solution to begin or continue in your digital transformation journey.  Read more about the [new Nonprofit Cloud](https://www.salesforce.com/blog/new-nonprofit-cloud/). Some key highlights:
+
+* Salesforce will to continue support our managed package products, including the Nonprofit Success Pack. Tens of thousands of customers use our current managed package products to achieve great results. 
+* Many of our ISV partners are building fantastic solutions for our managed packages as well as the new Nonprofit Cloud. We’re working with these partners to ensure that they understand our new product architecture, and are able to bring their years of experience and learnings to the new Nonprofit Cloud.
+* Salesforce remains deeply committed to nonprofit pricing. There are many new capabilities within the new Nonprofit Cloud and we work hard to maintain our nonprofit discounts across the new products. Our goals are to simplify access to nonprofit technology and make it easier for customers to get started.
+* Salesforce continues to grant free licenses with the Power of Us Program for the managed packages and Nonprofit Cloud. With Nonprofit Cloud, the Power of Us program also includes more features than ever to accelerate and deepen the nonprofit experience.
+* Take the new product for a test drive. Sign-up for a [Nonprofit Cloud Trial org](https://help.salesforce.com/s/articleView?id=sfdo.NPC_Create_Nonprofit_Cloud_Trial_Org.htm&type=5).
+* Visit the [Nonprofit Hub](https://trailhead.salesforce.com/trailblazer-community/groups/0F9300000001ocxCAA?tab=discussion&sort=LAST_MODIFIED_DATE_DESC) to chat with others about how nonprofits use Salesforce for social good.
+
+---
+### For Nonprofit Success Pack Users and admins
+
+* Check out existing [Nonprofit feature and enhancement requests](https://ideas.salesforce.com/s/search#t=All&sort=relevancy&f:@sfcategoryfull=[Nonprofit%7CNonprofit%20Cloud,Nonprofit%7CNonprofit%20Success%20Pack%20(NPSP)%20-%20Managed%20Package]).
+* [Ask questions or get help with the Nonprofit Success Pack](https://trailhead.salesforce.com/trailblazer-community/groups/0F94S000000kHitSAE)
+* [Ask for support or questions with other Nonprofit Users and Partners](https://trailhead.salesforce.com/trailblazer-community/groups/0F9300000001ocxCAA)
+* [Nonprofit Success Pack (NPSP) Documentation](https://help.salesforce.com/s/articleView?id=sfdo.Nonprofit_Success_Pack.htm)
+* [Release Notes](https://sfdc.co/bnL4Cb)
+* [Known Issues](https://issues.salesforce.com/#f[sfcategoryfull]=Nonprofit%7CNonprofit%20Success%20Pack%20(NPSP)%20-%20Managed%20Package)
+
+###  Try out the Nonprofit Success Pack
 
-#### Try it out
 You can install NPSP utilizing our custom application installer into any Developer Edition, Sandbox or Enterprise Edition Salesforce org.
-* <a href="https://install.salesforce.org/products/npsp" target="_blank">NPSP Installer</a>
 
-#### Meta
+* [NPSP Installer](https://install.salesforce.org/products/npsp)
+
+### Try out the New Nonprofit Cloud
+
+* [Nonprofit Cloud Learning Org Signup](https://help.salesforce.com/s/articleView?id=sfdo.NPC_Create_Nonprofit_Cloud_Trial_Org.htm&type=5)
 
-The Nonprofit Success Pack (“NPSP”) is an open-source package licensed by Salesforce.org (“SFDO”) under the BSD-3 Clause License, found at https://opensource.org/licenses/BSD-3-Clause. ANY MASTER SUBSCRIPTION AGREEMENT YOU OR YOUR ENTITY MAY HAVE WITH SFDO DOES NOT APPLY TO YOUR USE OF NPSP. NPSP IS PROVIDED “AS IS” AND AS AVAILABLE, AND SFDO MAKES NO WARRANTY OF ANY KIND REGARDING NPSP, WHETHER EXPRESS, IMPLIED, STATUTORY OR OTHERWISE, INCLUDING BUT NOT LIMITED TO ANY IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, FREEDOM FROM DEFECTS OR NON-INFRINGEMENT, TO THE MAXIMUM EXTENT PERMITTED BY APPLICABLE LAW.
-SFDO WILL HAVE NO LIABILITY ARISING OUT OF OR RELATED TO YOUR USE OF NPSP FOR ANY DIRECT DAMAGES OR FOR ANY LOST PROFITS, REVENUES, GOODWILL OR INDIRECT, SPECIAL, INCIDENTAL, CONSEQUENTIAL, EXEMPLARY, COVER, BUSINESS INTERRUPTION OR PUNITIVE DAMAGES, WHETHER AN ACTION IS IN CONTRACT OR TORT AND REGARDLESS OF THE THEORY OF LIABILITY, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGES OR IF A REMEDY OTHERWISE FAILS OF ITS ESSENTIAL PURPOSE. THE FOREGOING DISCLAIMER WILL NOT APPLY TO THE EXTENT PROHIBITED BY LAW. SFDO DISCLAIMS ALL LIABILITY AND INDEMNIFICATION OBLIGATIONS FOR ANY HARM OR DAMAGES CAUSED BY ANY THIRD-PARTY HOSTING PROVIDERS.
+### Meta
 
-_ducking-octo-happiness, laughing-archer_
+The Nonprofit Success Pack (“NPSP”) is an open-source package licensed by Salesforce.org (“SFDO”) under the BSD-3 Clause License, found at https://opensource.org/licenses/BSD-3-Clause. ANY MASTER SUBSCRIPTION AGREEMENT YOU OR YOUR ENTITY MAY HAVE WITH SFDO DOES NOT APPLY TO YOUR USE OF NPSP. NPSP IS PROVIDED “AS IS” AND AS AVAILABLE, AND SFDO MAKES NO WARRANTY OF ANY KIND REGARDING NPSP, WHETHER EXPRESS, IMPLIED, STATUTORY OR OTHERWISE, INCLUDING BUT NOT LIMITED TO ANY IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, FREEDOM FROM DEFECTS OR NON-INFRINGEMENT, TO THE MAXIMUM EXTENT PERMITTED BY APPLICABLE LAW. SFDO WILL HAVE NO LIABILITY ARISING OUT OF OR RELATED TO YOUR USE OF NPSP FOR ANY DIRECT DAMAGES OR FOR ANY LOST PROFITS, REVENUES, GOODWILL OR INDIRECT, SPECIAL, INCIDENTAL, CONSEQUENTIAL, EXEMPLARY, COVER, BUSINESS INTERRUPTION OR PUNITIVE DAMAGES, WHETHER AN ACTION IS IN CONTRACT OR TORT AND REGARDLESS OF THE THEORY OF LIABILITY, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGES OR IF A REMEDY OTHERWISE FAILS OF ITS ESSENTIAL PURPOSE. THE FOREGOING DISCLAIMER WILL NOT APPLY TO THE EXTENT PROHIBITED BY LAW. SFDO DISCLAIMS ALL LIABILITY AND INDEMNIFICATION OBLIGATIONS FOR ANY HARM OR DAMAGES CAUSED BY ANY THIRD-PARTY HOSTING PROVIDERS.

StaticResourceSources/npsp-slds/npsp-common.css

@@ -17,6 +17,7 @@ input.lookupInput {
 input.lookupInputSLDS {
     width: 100%;
     margin-right: -30px !important;
+    border-color: #747474 !important;
 }
 body .dateInput input[type="text"], .slds-vf-scope .dateInput input[type="text"] {
     margin-left: 0;

cumulusci.yml

@@ -1,4 +1,4 @@
-minimum_cumulusci_version: 3.23.0
+minimum_cumulusci_version: 3.74.0
 project:
     name: Cumulus
     source_format: sfdx
@@ -221,13 +221,18 @@ tasks:
         options:
             update_future_releases: True
 
+    github_release:
+        options:
+            release_content: |
+                Check out the [Salesforce Release Notes](https://sfdc.co/bnL4Cb) or [Known Issues](https://issues.salesforce.com/) for details.
+
     github_release_notes:
         options:
             trial_info: "`TBD`"
 
     is_rd2_enabled:
         description: This preflight check ensures that Enhanced Recurring Donations is enabled
-        class_path: tasks.is_rd2_enabled
+        class_path: tasks.check_rd2_enablement.is_rd2_enabled
         group: NPSP
 
     robot:
@@ -769,6 +774,12 @@ tasks:
                 - "*.cls"
 
 flows:
+
+    release_production:
+        steps:
+            3:
+                task: None
+
     build_unlocked_test_package:
         steps:
             0:

force-app/main/default/aura/RD2_EnablementDelegate/RD2_EnablementDelegate.cmp

@@ -55,8 +55,9 @@
     <lightning:layout horizontalAlign="spread" multipleRows="true" class="slds-hide" aura:id="enablementDisabled">
         <lightning:layoutItem padding="horizontal-large" size="10">
             <div class="slds-illustration slds-illustration_large">
-                <br /><br />
-                <img src="/img/chatter/OpenRoad.svg" class="slds-illustration__svg" alt="OpenRoad" />
+                <div class="slds-m-vertical_medium">
+                    <img src="/img/chatter/OpenRoad.svg" class="slds-illustration__svg" alt="OpenRoad" />
+                </div>
                 <div class="slds-text-longform">
                     <h3 class="slds-text-heading_medium">{!$Label.c.RD2_EnablementDisabledHeader}</h3>
                     <p>
@@ -77,7 +78,9 @@
 
         <lightning:layoutItem padding="horizontal-large" class="slds-p-top_large" size="12">
             <lightning:layout multipleRows="true">
-                <h2 class="title slds-text-heading_small">{!$Label.c.RD2_EnablementPrepTitle}</h2>
+                <lightning:layoutItem size="12">
+                    <h2 class="title slds-text-heading_small">{!$Label.c.RD2_EnablementPrepTitle}</h2>
+                </lightning:layoutItem>
                 <lightning:layoutItem class="slds-p-top_small" size="12">
                     <lightning:formattedRichText class="slds-text-longform"
                         value="{!$Label.c.RD2_EnablementPrepIntro}" />

force-app/main/default/aura/RD2_EnablementDelegate/RD2_EnablementDelegateController.js

@@ -28,6 +28,16 @@
         helper.handleBatchEvent(component, event, 'v.dryRunBatch');
         helper.refreshDryRun(component);
         helper.refreshEnable(component);
+        var status = event.Hp.batchProgress.status;
+        var dryRunJob = component.find("dryRunJob");
+        if (["Completed", "Aborted"].includes(status)) {
+            if(dryRunJob){
+                helper.setFocus(component, 'dryRunJob');
+            }
+            else{
+                helper.setFocus(component, 'dryRun2Job');
+            }
+        }
     },
     handleDryRunError: function (component, event, helper) {
         helper.handleBatchError(component, event, 'dryRun');
@@ -44,6 +54,10 @@
     handleMigrationStatusChange: function (component, event, helper) {
         helper.handleBatchEvent(component, event, 'v.migrationBatch');
         helper.refreshMigration(component);
+        var status = event.Hp.batchProgress.status;
+            if (["Completed", "Aborted"].includes(status)) {
+                helper.setFocus(component, 'migrationJob');
+            }
     },
     handleMigrationError: function (component, event, helper) {
         helper.handleBatchError(component, event, 'migration');

force-app/main/default/aura/RD2_EnablementDelegate/RD2_EnablementDelegateHelper.js

@@ -599,5 +599,22 @@
     hideSpinner: function (component, element) {
         var spinner = component.find(element);
         $A.util.addClass(spinner, 'slds-hide');
-    }
+    },
+    /**
+     * @description: Autofocus 
+     */
+    setFocus: function (component, elementId) {
+        window.setTimeout(() => { 
+           try { var element = component.find(elementId); 
+               if (element) { 
+                   element.getElement().setAttribute('tabindex', '0'); 
+                   element.getElement().focus(); 
+                   element.getElement().setAttribute('tabindex', '-1'); 
+               } 
+           } catch (error) { 
+                   console.error('Error setting focus on element:', error); 
+
+           } 
+           }, 0); 
+   }
 })

force-app/main/default/classes/ACCT_ViewOverride_CTRL.cls

@@ -47,7 +47,10 @@ public with sharing class  ACCT_ViewOverride_CTRL {
     public ACCT_ViewOverride_CTRL (ApexPages.StandardController controller)
     {
         //get the account with the npe01__one2oneContact__c field for use in the rederict if necessary
-        List <Account> accounts = [select id, npe01__one2oneContact__c, npe01__SYSTEM_AccountType__c from Account where id = :ApexPages.currentPage().getParameters().get('id')];
+        // WITH SECURITY_ENFORCED isn't really necessary, but it won't hurt anything and should pass automated
+        // security checks
+        List <Account> accounts = [select id, npe01__one2oneContact__c, npe01__SYSTEM_AccountType__c
+            from Account where id = :ApexPages.currentPage().getParameters().get('id') WITH SECURITY_ENFORCED];
         if (accounts.size() > 0)
         {
             account = accounts[0];

force-app/main/default/classes/ALLO_ManageAllocations_CTRL.cls

@@ -52,6 +52,69 @@ public with sharing class ALLO_ManageAllocations_CTRL {
         set;
     }
 
+    private Boolean canCreate {
+        get {
+            if (this.canCreate == null) {
+                this.canCreate = this.checkCreate();
+            }
+
+            return this.canCreate;
+        }
+        set;
+    }
+
+    private Boolean canDelete {
+        get {
+            if (this.canDelete == null) {
+                this.canDelete = this.checkDelete();
+            }
+
+            return this.canDelete;
+        }
+        set;
+    }
+
+    private Boolean canUpdate {
+        get {
+            if (this.canUpdate == null) {
+                this.canUpdate = this.checkUpdate();
+            }
+
+            return this.canUpdate;
+        }
+        set;
+    }
+
+    private Set<SObjectField> getFieldsForFLSCheck() {
+        Set<SObjectField> objectFields = new Set<SObjectField>();
+
+        objectFields.add(Allocation__c.Amount__c.getDescribe().getSobjectField());
+        objectFields.add(Allocation__c.Percent__c.getDescribe().getSobjectField());
+        objectFields.add(Allocation__c.General_Accounting_Unit__c.getDescribe().getSobjectField());
+
+        for(Schema.FieldSetMember additionalField : additionalAllocationFields) {
+            Schema.DescribeFieldResult fieldResult = additionalField.getSObjectField().getDescribe();
+            if (fieldResult.isCalculated() || !fieldResult.permissionable || additionalField.getFieldPath().contains('__r')) {
+                continue;
+            }
+            objectFields.add(additionalField.getSObjectField());
+        }
+
+        return objectFields;
+    }
+
+    private Boolean checkCreate() {
+        return UTIL_Permissions.getInstance().canCreate(Allocation__c.SObjectType, fieldsForFLSCheck);
+    }
+
+    private Boolean checkDelete() {
+        return UTIL_Permissions.getInstance().canDelete(Allocation__c.SObjectType);
+    }
+
+    private Boolean checkUpdate() {
+        return UTIL_Permissions.getInstance().canUpdate(Allocation__c.SObjectType, fieldsForFLSCheck);
+    }
+
     public String getNamespace() {
         return UTIL_Namespace.getComponentNamespace();
     }
@@ -69,6 +132,16 @@ public with sharing class ALLO_ManageAllocations_CTRL {
         set;
     }
 
+    private Set<SObjectField> fieldsForFLSCheck {
+        get {
+            if (fieldsForFLSCheck == null) {
+                fieldsForFLSCheck = getFieldsForFLSCheck();
+            }
+            return fieldsForFLSCheck;
+        }
+        set;
+    }
+
     /** @description List of allocations to delete when the user clicks Save.*/
     public list<Allocation__c> allocationsToBeDeleted = new list<Allocation__c>();
     /** @description The id of the parent object; Opportunity, Campaign, or Recurring Donation.*/
@@ -295,6 +368,9 @@ public with sharing class ALLO_ManageAllocations_CTRL {
         Savepoint sp = Database.setSavepoint(); 
         try {
             if (!allocationsToBeDeleted.isEmpty()) {
+                if (!canDelete) {
+                    UTIL_AuraEnabledCommon.throwAuraHandledException(System.Label.commonAccessErrorMessage);
+                }
                 TDTM_ProcessControl.setRecursionFlag(TDTM_ProcessControl.flag.ALLOC, false);
                 delete allocationsToBeDeleted;
 
@@ -309,11 +385,17 @@ public with sharing class ALLO_ManageAllocations_CTRL {
             }
 
             if (!listAlloForUpdate.isEmpty()) {
+                if (!canUpdate) {
+                    UTIL_AuraEnabledCommon.throwAuraHandledException(System.Label.commonAccessErrorMessage);
+                }
                 TDTM_ProcessControl.setRecursionFlag(TDTM_ProcessControl.flag.ALLOC, false);
                 update listAlloForUpdate;
             }
 
             if (!listAlloForInsert.isEmpty()) {
+                if (!canCreate) {
+                    UTIL_AuraEnabledCommon.throwAuraHandledException(System.Label.commonAccessErrorMessage);
+                }
                 TDTM_ProcessControl.setRecursionFlag(TDTM_ProcessControl.flag.ALLOC, false);
                 insert listAlloForInsert;
             }
@@ -354,7 +436,7 @@ public with sharing class ALLO_ManageAllocations_CTRL {
             new ApexPages.Message(
                     ApexPages.Severity.WARNING,
                     String.format(
-                        System.Label.exceptionDeletePermission,
+                        System.Label.commonAccessErrorMessage,
                         new String[]{UTIL_Describe.getObjectLabel(UTIL_Namespace.StrTokenNSPrefix('Allocation__c'))})));
 
     }