Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y WCAG 2.1 color contrast updates #7190

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

npsp-reedestockton
Copy link
Contributor

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

@npsp-reedestockton
Copy link
Contributor Author

Copy link
Contributor

@lparrott lparrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The bulk of my testing will be spent on the checkbox changes, just because there's a small risk of regression there. I'll approve after testing.

<apex:inputCheckbox value="{!selection[g.Id]}" id="cbGift">
<apex:actionSupport action="{!refresh}" event="onchange" rerender="totalSelected, totalUn" />
</apex:inputCheckbox>
<div class="slds-form-element__control">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

force-app/main/default/pages/STG_PanelContactRoles.page Outdated Show resolved Hide resolved
force-app/main/default/pages/STG_PanelAllocations.page Outdated Show resolved Hide resolved
@@ -54,7 +54,7 @@
<apex:outputLabel value="{!$ObjectType.Trigger_Handler__c.Fields.Class__c.Label}" for="tbxC" styleClass="slds-form-element__label"
/>
<div class="slds-form-element__control">
<apex:inputField value="{!thNew.Class__c}" required="false" id="tbxC" html-aria-describedby="{!$Component.tbxCHelp}" styleClass="fslds-input"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we both know what the "f" stands for

@lparrott lparrott self-requested a review September 8, 2023 16:56
@npsp-reedestockton npsp-reedestockton merged commit 0cc76cf into feature/248 Sep 8, 2023
4 of 11 checks passed
@npsp-reedestockton npsp-reedestockton deleted the feature/248__a11y-contrast branch September 8, 2023 17:50
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants