Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-14204419 - Update RD2 preflight class_path to work-around installer errors #7198

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

force2b
Copy link
Contributor

@force2b force2b commented Oct 9, 2023

A recent change to CumulusCI resulted in a regression for certain custom tasks. Before this commit:

$ cci task run is_rd2_enabled
Error: module 'tasks' has no attribute 'is_rd2_enabled'

Run this command for more information about debugging errors: cci error --help

This resulted in an error when running preflight checks for the enhanced-recurring-donations plan in MetaDeploy. After:

$ cci task run is_rd2_enabled
is_rd2_enabled

  Description: This preflight check ensures that Enhanced Recurring Donations is enabled

  Class: tasks.check_rd2_enablement.is_rd2_enabled
[...]

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

A recent change to CumulusCI resulted in a regression for certain custom
tasks. Before this commit:

```console
$ cci task run is_rd2_enabled
Error: module 'tasks' has no attribute 'is_rd2_enabled'

Run this command for more information about debugging errors: cci error --help
```

This resulted in an error when running preflight checks for the
`enhanced-recurring-donations` plan in MetaDeploy. After:

```console
$ cci task run is_rd2_enabled
is_rd2_enabled

  Description: This preflight check ensures that Enhanced Recurring Donations is enabled

  Class: tasks.check_rd2_enablement.is_rd2_enabled
[...]
```
@force2b force2b added the Infrastructure Robot, CCI and other related work label Oct 9, 2023
@force2b force2b requested a review from a team as a code owner October 9, 2023 17:18
@force2b force2b requested a review from jstvz October 9, 2023 17:18
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Hi 👋 @force2b! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

@force2b force2b merged commit 53157c1 into main Oct 9, 2023
10 of 14 checks passed
@force2b force2b deleted the feature/rd2-workaround branch October 9, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Robot, CCI and other related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants