Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W-8828011] Latest Definition of Done #80

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

spelak-salesforce
Copy link
Contributor

@spelak-salesforce spelak-salesforce commented Feb 1, 2021

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 馃敀 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 馃攽 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

@spelak-salesforce spelak-salesforce requested a review from a team as a code owner February 1, 2021 20:10
@spelak-salesforce
Copy link
Contributor Author

W-8828011

@spelak-salesforce spelak-salesforce changed the title Latest Definition of Done [W-8828011] Latest Definition of Done Feb 1, 2021
@spelak-salesforce spelak-salesforce added no QE needed No changes to metadata directly related to Managed Package needs for dev review Ready for Developer review 馃幆 this sprint This Pull Request is related to a Work Item committed in this sprint labels Feb 1, 2021
Copy link

@seanpat09 seanpat09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spelak-salesforce looks good!

@seanpat09 seanpat09 added in dev review Developer is actively reviewing and removed needs for dev review Ready for Developer review labels Feb 2, 2021
@spelak-salesforce
Copy link
Contributor Author

@davidmreed or @SalesforceFoundation/release-engineering-reviewers

Can you review this PR? I see in CODEOWNERS that any changes to .github needs a code owner review. Thank you!

@spelak-salesforce spelak-salesforce merged commit abc61a7 into master Feb 3, 2021
@spelak-salesforce spelak-salesforce deleted the feature/dod branch February 3, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in dev review Developer is actively reviewing no QE needed No changes to metadata directly related to Managed Package 馃幆 this sprint This Pull Request is related to a Work Item committed in this sprint
Projects
None yet
3 participants