Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move entry points from setup.py to setup.cfg #13

Merged
merged 1 commit into from Nov 1, 2021

Conversation

douglatornell
Copy link
Member

Supported by setuptools>=51.0.0 since 6-Dec-2020.

This is a step along the way of modernizing packaging.

Supported by setuptools>=51.0.0 since 6-Dec-2020.
@douglatornell douglatornell self-assigned this Nov 1, 2021
@douglatornell douglatornell added the enhancement New feature or request label Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #13 (a266935) into main (16ddb48) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          11       11           
  Lines        1297     1297           
  Branches       88       88           
=======================================
  Hits         1234     1234           
  Misses         59       59           
  Partials        4        4           
Flag Coverage Δ
unittests 95.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ddb48...a266935. Read the comment docs.

@douglatornell
Copy link
Member Author

Testing on graham.

  • Installation was fine
  • salishsea run successfully prepared and queued a run

@douglatornell
Copy link
Member Author

NEMO run and restart file rebuilding was successful.

@douglatornell douglatornell merged commit 71b3eb9 into main Nov 1, 2021
@douglatornell douglatornell deleted the setup_cfg_entry_points branch November 1, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant