Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --cores-per-node & --cpu-arch options to run sub-command #18

Merged
merged 6 commits into from Jul 8, 2022

Conversation

douglatornell
Copy link
Member

Replacement for --cedar-broadwell flag because we need to be able to specify cores/node
and CPU architecture for sockeye now too.

Working towards replacement of --cedar-broadwell flag because we need to be
able to specify cores/node and CPU architecture for sockeye now too.
@douglatornell douglatornell self-assigned this Jul 7, 2022
@douglatornell douglatornell added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #18 (8e946e9) into main (74b9275) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   95.14%   95.15%   +0.01%     
==========================================
  Files          11       11              
  Lines        1297     1301       +4     
  Branches      166      166              
==========================================
+ Hits         1234     1238       +4     
  Misses         59       59              
  Partials        4        4              
Flag Coverage Δ
unittests 95.15% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
salishsea_cmd/run.py 97.53% <100.00%> (-0.01%) ⬇️
tests/test_run.py 99.65% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b9275...8e946e9. Read the comment docs.

@douglatornell douglatornell added this to the v22.2 milestone Jul 7, 2022
@douglatornell douglatornell marked this pull request as draft July 7, 2022 01:17
Working towards replacement of --cedar-broadwell flag because we need to be
able to specify cores/node and CPU architecture for sockeye now too.
@douglatornell
Copy link
Member Author

Successfully tested by @SusanEAllen on sockeye.

Replaced by --cores-per-node and --cpu-arch options because we need to be
able to specify cores/node and CPU architecture for sockeye now too.
Eliminates odd highlighting in text blocks.
Found by sphinx linkcheck.
@douglatornell douglatornell marked this pull request as ready for review July 8, 2022 20:12
@douglatornell douglatornell merged commit 405e9f3 into main Jul 8, 2022
@douglatornell douglatornell deleted the cores_cpuarch_opts branch July 9, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant