Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GitHub Actions jobs to use reusable workflows #139

Merged
merged 16 commits into from Dec 23, 2022

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Dec 23, 2022

re: issue #120

Reusable workflows are in UBC-MOAD/gha-workflows

  • Add .github/dependabot.yaml to check for action version updated and generate PRs
  • Subscribe to repo workflows on Slack
    /github subscribe SalishSeaCast/SalishSeaNowcast workflows:{event:"pull_request","push" branch:"main"}
  • Add editable VCS installs of SalishSeaCast and MOAD pkgs to environment-test.yaml
  • Update codeql-analysis.yaml
  • Update and rename docs-linkcheck.yaml
  • Update and rename pytest-coverage.yaml
  • Confirm badge URLs in README and dev docs
  • Delete repo secrets in favour of org secrets

Check Actions versions weekly and create PRs to update them as necessary.
@douglatornell douglatornell added the maintenance Codebase maintenance label Dec 23, 2022
@douglatornell douglatornell added this to the v22.1 milestone Dec 23, 2022
@douglatornell douglatornell linked an issue Dec 23, 2022 that may be closed by this pull request
8 tasks
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #139 (bc81ad7) into main (ac7ff1a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   73.92%   73.92%           
=======================================
  Files         127      127           
  Lines       16682    16682           
  Branches     1183     1183           
=======================================
  Hits        12333    12333           
  Misses       4299     4299           
  Partials       50       50           
Flag Coverage Δ
unittests 73.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Expected in text env by reusable GHA workflows
* Necessary in rtd env so that `importlib.metadata.version()` can work
Workflow file name changed to sphinx-linkcheck
* Workflow file name and name in GitHub Actions web UI changed to
  pytest-with-coverage
* Workflow badges updated in README and dev docs
Installation using GitLab access token may be troublesome, so let's see if the
workflow can succeed without the OPPTools package in the env.
Test suite has 18 failing tests without OPPTools pkg installed, so let's try
harder to get it installed in the env.
Can't figure out how to get GitLab access token secret into test env description
through reusable workflow, so special case it is.
pytest test collection gets very confused otherwise.
Separating from the env for pytest-with-coverage so that we can use the
reusable sphinx-linkcheck workflow. Necessary because pip installation via
conda env YAML files doesn't support the --src option that we need for the
pytest workflow.
Necessary because pip installation via conda env YAML files doesn't support the
--src option that we need.
Hope to resolve cartopy wheel build error on readthedocs.
@douglatornell douglatornell merged commit 037b246 into main Dec 23, 2022
@douglatornell douglatornell deleted the 120-gha-reusable-workflows branch December 23, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Codebase maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change GitHub Actions jobs to use reusable workflows
1 participant