Update make_live_ocean_files re: single filepath #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed not informative "Set up and run the worker." line at the beginning. re: issue #121
`salishsea_tools.LiveOcean_BCs.create_LiveOcean_TS_BCs()` returns a single filepath not a list of filepaths. As a result of this change, the related logging message and checklist assignment have been updated and corresponding test cases have been adjusted as well.
douglatornell
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 77.63% 77.63%
=======================================
Files 133 133
Lines 18686 18686
Branches 1910 1910
=======================================
Hits 14506 14506
Misses 4113 4113
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salishsea_tools.LiveOcean_BCs.create_LiveOcean_TS_BCs()returns a singlefilepath not a list of filepaths. As a result of this change, the related
logging message and checklist assignment have been updated and corresponding
test cases have been adjusted as well.
Also update
make_live_ocean_filesworkermain()function docstring to remove not informative "Set up and run the worker." line at the beginning.re: issue #121