Allow passing mutliple QROptions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have seen #7 which is great 馃憤馃徏 However, it would be more efficient passing all the options according to the user needs (since QROptions has multiple options). Also, this allows the user to utilize any added features to the `chillerlan\QRCode` package in the future 馃挕 An example for scale would be: ```php $displayQRCodeAsBase64 = GenerateQrCode::fromArray([ ..... ])->render(['scale' => 3]); ``` PS. Thanks for this simple yet elegant solution .. you saved a lot of time for many developers including myself 鉂わ笍
|
@ali-alharthi thanks, this will introduce a brack change, will be released under v2.0 |
|
@salkhwlani understandable 馃憤馃徏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen #7 which is great 馃憤馃徏
However, it would be more efficient passing all the options according to the user needs (since QROptions has multiple options).
Also, this allows the user to utilize any added features to the
chillerlan\QRCodepackage in the future 馃挕An example for scale would be:
PS. Thanks for this simple yet elegant solution .. you saved a lot of time for many developers including myself 鉂わ笍