2.0.0 Update #11
Merged
2.0.0 Update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Version bump to 2.0.0 - Added more API related functions for external plugins - Moved files to the SalmonDE\TopVoter namespace to match the plugin guidelines of pmmp more - Moved events to an EventListener for more tidiness (There's still none ;-;) - Possibly prevented a bug
I forgot to edit the namespace inside the plugin.yml file
switch the two arguments for $pluginManager->registerEvents()
|
@Aericio merge as soon you think it's ready. <3 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guidelines of pmmp
;-;)
However, this wasn't tested in any way yet, so I'd be really glad for reviewers. ;)