Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks #1

Merged
merged 10 commits into from
Jun 19, 2018
Merged

Benchmarks #1

merged 10 commits into from
Jun 19, 2018

Conversation

lemire
Copy link
Collaborator

@lemire lemire commented Jun 13, 2018

Simple benchmark to check that the performance can be good. (You should run this yourself.)

@SalvatorePreviti
Copy link
Owner

Hello, didn't have time before to check or reply, had some work to do and I was concentrated in completing the AVX2 + SSE4 support that is now available in version 0.2.5.

Is very good to have a benchmark, and I really like it and the way this is done. Would like to integrate it.

However, is there a particular reason to create a separate npm package?
Usually to do benchmarks I create a benchmark.js in the ./scripts folder that would not be published together with the npm package. I would then add a "npm run benchmarks" in package.json that can be run when you do a git pull of the repository.
Is there a particular reason to have a separate package?

Thanks :)

@lemire
Copy link
Collaborator Author

lemire commented Jun 14, 2018

Is very good to have a benchmark

I would recommend building a benchmark you like, running it and posting your results in the README so people know whether it is fast.

However, is there a particular reason to create a separate npm package?

Just convenience. There are dependencies. You have to import these dependencies. I don't really care.

You can throw away this PR, doesn't matter to me. You may want to build from it, however.

@SalvatorePreviti
Copy link
Owner

Sure, tomorrow will pull this and do some commits. The dependencies are fine if kept in devDependencies. Thanks :)

@SalvatorePreviti SalvatorePreviti merged commit f35f0b5 into master Jun 19, 2018
@SalvatorePreviti SalvatorePreviti deleted the benchmarks branch June 19, 2018 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants