Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the noise, I wanted to raise an issue, but issues are disabled at this time on your project.
I'm working on a cordova (hybrid framework for mobile development) project. It's based on jQuery; recently I switched to a NPM-based workflow and your module works great, as you mention I can use browserify-it and all is good.
Before the NPM switch, I used vanilla jQuery (on a previous cordova project) and a custom jquery mobile build, just for the events. The strategy I'm using involves registering namespaced events on each "page" of the SPA and it works great. I can wipe all the registered events while switching between pages and keep things sane. I'm using $(element).on(event.namespace) and off.(event.namespace)
So: After switching from the custom jquery mobile build to NPM, using your module, I'm getting event leakage on some events. swipe gets registered by itself multiple times and does not go away. swiperight and swipeleft do get cleared correctly when I do $(element).off('swiperight.namespace') for example.
Does all this make sense? If maybe all this is does not fall into your use cases, could you point me to where should I begin to fix this?
Thanks!