Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGMenuListener does not handle InventoryDragEvent #14

Closed
Phoenix616 opened this issue May 16, 2022 · 3 comments
Closed

SGMenuListener does not handle InventoryDragEvent #14

Phoenix616 opened this issue May 16, 2022 · 3 comments

Comments

@Phoenix616
Copy link

Currently this library does not handle the InventoryDragEvent which means that one could modify an otherwise protected inventory by dragging instead of clicking.

Also "clicks" could go missing and annoy players as even moving the mouse a single pixel while clicking will be counted as a drag, not click event.

@SamJakob
Copy link
Owner

Thanks for pointing this out.
How do you suggest it should be handled? Additional event handlers? Defer to the click event listener? Or just cancel it?

@Phoenix616
Copy link
Author

Best would probably to just forward to the click logic and cancel it depending on what that does.

@SamJakob
Copy link
Owner

Okay, sounds good. Will add when I next get time to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants