Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated V4.3.2 to NodeJS16 #329

Closed
wants to merge 3 commits into from
Closed

Conversation

Olzie-12
Copy link

No description provided.

@Olzie-12 Olzie-12 changed the title Updated V4.3.3 to NodeJS16 Updated V4.3.2 to NodeJS16 Oct 18, 2022
@Luisisinka
Copy link

Update for node version 16 would be appreciated. Thanks

Copy link

@Silloky Silloky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seem fine...

@SamKirkland
Copy link
Owner

Hello. Thanks for the PR

I merged PR #338 instead because it didn't have changes to index.js
Going to cut a release soon - v4.3.3 will be using nodev16

@SamKirkland SamKirkland closed this Dec 2, 2022
@Olzie-12
Copy link
Author

Olzie-12 commented Dec 2, 2022

Hello. Thanks for the PR

I merged PR #338 instead because it didn't have changes to index.js Going to cut a release soon - v4.3.3 will be using nodev16

No problem because sometimes when I upload the files it doesn’t actually update the needed files and i facts just replaces them with some other random jar. That’s why I made them changes as well. Hopefully you can actually fix that issue though

@SamKirkland
Copy link
Owner

@Olzie-12 can you open an issue with recreation steps and I can take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants