Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force override to basic-ftp ^5.0.0 (fixes #322) #380

Closed
wants to merge 2 commits into from
Closed

Force override to basic-ftp ^5.0.0 (fixes #322) #380

wants to merge 2 commits into from

Conversation

yelper
Copy link

@yelper yelper commented Mar 4, 2023

Force a package override to use basic-ftp ^5.0.0. This fixes the issue I raised in #322.

Alternative fix:

  • Update package reference in SamKirkland/FTP-Deploy to use basic-ftp ^5.0.0
  • Publish new minor version of SamKirkland/FTP-Deploy
  • Reference new minor version in this project and push new version

@yelper yelper mentioned this pull request Mar 4, 2023
Closed
@SamKirkland
Copy link
Owner

Thanks for the PR Alper

I prefer the alternative fix.
I just pushed v1.2.3 of ftp-deploy which upgrades basic-ftp.

v4.3.4 of ftp-deploy-action will use the latest version of ftp-deploy

@SamKirkland SamKirkland mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yelper @SamKirkland