Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue about keypoint localization #1

Closed
LiUzHiAn opened this issue Aug 24, 2019 · 1 comment
Closed

issue about keypoint localization #1

LiUzHiAn opened this issue Aug 24, 2019 · 1 comment

Comments

@LiUzHiAn
Copy link

Hi, @SamL98

I got a little confused about the Line 43 in keypoints.py, it wrote offset = -LA.inv(HD).dot(J). You defined the HD as a 3 by 3 array, and the shape of J is 1 by 3. How that possible to use a dot operation between them?

@SamL98
Copy link
Owner

SamL98 commented Aug 25, 2019

The shape of J is actually 3x1 as 1D arrays are treated as column vectors by default. Therefore, performing a dot product between a 3x3 array, or matrix, and a 3x1 vector simply results in a 3x1 vector. To be able to fully understand the code and SIFT in general, linear algebra knowledge is quite important.

Also, as a side note, I do not maintain this repository anymore. I believe this fork: https://github.com/HamidNE/machines-vision-sift-algorithm, is currently maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants