-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables multiple file upload on MatFileInput component #519
Enables multiple file upload on MatFileInput component #519
Conversation
…nent. The documentation already supports this.
I think that instead of just adding |
Nice feature |
Agreed. Multiple should be an optional parameter passed to the component. |
Great idea, I'll wire that up and update the PR. |
@jacomarcon please let me know the status of this PR. If you are going to update it or if it is already finished. Please use develop branch for the PR. When you are finished we will review. Thanks! |
Heya @enkodellc I've got it coded up, need to test/commit and I'll get it updated. Should have some time to work on it this upcoming weekend. |
@jacomarcon just let us know when it is complete and we will review. Thanks! |
… multiple uploads are allowed.
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
Changes to allow single or multiple file upload is complete. @enkodellc let me know if there is anything else I need to do to get it merged in. |
Great, I will take a look at it soon, most likely tomorrow. |
@jacomarcon I just did a quick code review. We appreciate your contribution! Next time please add a demo example for ease of testing. I will submit a PR for that. |
Add Multiple File Upload demo for PR #519
The documentation for MatFileInput gives an example of being able to select or drop multiple files into the component for processing. The component currently only allows single file selection. This change enables the multiple file selection/drop into the component.