Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables multiple file upload on MatFileInput component #519

Merged

Conversation

jacomarcon
Copy link
Contributor

The documentation for MatFileInput gives an example of being able to select or drop multiple files into the component for processing. The component currently only allows single file selection. This change enables the multiple file selection/drop into the component.

…nent. The documentation already supports this.
@jacomarcon
Copy link
Contributor Author

jacomarcon commented Apr 28, 2020

Addresses issues #435 and #489.

@EduVencovsky
Copy link
Contributor

I think that instead of just adding multiple it should be a bool parameter to decide if it's multiple or not.

@SamProf SamProf changed the base branch from master to develop April 30, 2020 16:37
@SamProf
Copy link
Owner

SamProf commented Apr 30, 2020

Nice feature
It would be good if multiple attribute will be optional.
What you think?

@RedFolder
Copy link
Contributor

Agreed. Multiple should be an optional parameter passed to the component.

@jacomarcon
Copy link
Contributor Author

Great idea, I'll wire that up and update the PR.

@enkodellc
Copy link
Collaborator

@jacomarcon please let me know the status of this PR. If you are going to update it or if it is already finished. Please use develop branch for the PR. When you are finished we will review. Thanks!

@jacomarcon
Copy link
Contributor Author

Heya @enkodellc I've got it coded up, need to test/commit and I'll get it updated. Should have some time to work on it this upcoming weekend.

@enkodellc
Copy link
Collaborator

@jacomarcon just let us know when it is complete and we will review. Thanks!

@ghost
Copy link

ghost commented Jun 7, 2020

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@jacomarcon
Copy link
Contributor Author

Changes to allow single or multiple file upload is complete. @enkodellc let me know if there is anything else I need to do to get it merged in.

@enkodellc
Copy link
Collaborator

Great, I will take a look at it soon, most likely tomorrow.

@enkodellc
Copy link
Collaborator

@jacomarcon I just did a quick code review. We appreciate your contribution! Next time please add a demo example for ease of testing. I will submit a PR for that.

@enkodellc enkodellc merged commit f6cddcd into SamProf:develop Jun 16, 2020
enkodellc added a commit that referenced this pull request Jun 16, 2020
Add Multiple File Upload demo for PR #519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants