Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper Text Created #569

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Helper Text Created #569

merged 1 commit into from
Jun 13, 2020

Conversation

EduVencovsky
Copy link
Contributor

Created MatHelperText component following material design guide lines.

The reason I created this is because it would be good to have a standard component and remove some logic from MatTextField.

This will also enable user to use it if they need for some special reason.

And now I have a few question for the contributors for further improvements.

  • As I created a parameter called CharacterCount, should I add a parameter in the MatTextField for that too?
  • What do you guys think about creating a component for each different part of the MatTextField just like react's material version, where they have 6 components that can compose TextField component? (You can see another mention of this here)
  • While looking at the material design docs and the code of MatBlazor, I realized that the HelperText of TextField and Select is different, so I didn't implement it and now we need to make a decision on how to handle this diference.
    • Create another component for the Select's HelperText
    • Create a parameter for HelperText that will say to use the Select's HelperText
    • Create parameters that can be used to make changes to look like Select's HelperText or TextField's HelperText (e.g. create a parameter for margin)

Hope you guys enjoy, thanks for everything!

@enkodellc enkodellc requested a review from SamProf May 26, 2020 03:07
@SamProf
Copy link
Owner

SamProf commented Jun 13, 2020

I think this is good start, later someone can reuse this component in other parts of MatBlazor components.

Thank you, @EduVencovsky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants