Update the slow methods to match ActiveSupport’s current implementation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool we should also update the readme to clarify new perf numbers. |
SamSaffron
added a commit
that referenced
this pull request
Aug 3, 2015
Update the slow methods to match ActiveSupport’s current implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport's
String#blank?has gone through some changes -- this updates the test and benchmark comparison methods to match its current implementation.Particularly notable is that it has been made more performant, via rails/rails#12976 and rails/rails#13519. fast_blank still handily beats it, but it's less of a landslide.
Before:
After: