Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for reivew. #4

Merged
merged 1 commit into from Oct 8, 2019
Merged

Fix issues for reivew. #4

merged 1 commit into from Oct 8, 2019

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Oct 7, 2019

Hi,
I could pass the review for the ticket https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c35 .
This is the updated version. I wish you merge it.

By the way, I requested to create the htslib repository and branches.
https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c35 .

But it was declined, because I am not the creator of the bugzilla ticket.
https://pagure.io/releng/fedora-scm-requests/issue/17763#comment-602780

So, I need to ask you to request the repository.
See https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c35 review process document. This is what you need to do.

Thank you.

@SamStudio8 SamStudio8 merged commit f4987c4 into SamStudio8:master Oct 8, 2019
@SamStudio8
Copy link
Owner

Thanks Jun!

@junaruga
Copy link
Contributor Author

junaruga commented Oct 9, 2019

Hi Sam, I am asking Fedora to get a "sponsor" role for my account to be a sponsor of you.
But I am not sure that I can get it.
https://pagure.io/packager-sponsors/issue/402

To create the repository on Fedora, I like you to get a sponsor from someone.

Here the documents.

@SamStudio8
Copy link
Owner

SamStudio8 commented Oct 9, 2019 via email

@junaruga
Copy link
Contributor Author

junaruga commented Oct 9, 2019

Sure, okay. I will open own review request, closing current ticket like

https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c37
alternatively create your own review request and close this bug as duplicate and block this bug as FE-DEADREVIEW. If Sam request the package, he will be the maintainer and not you.

@SamStudio8
Copy link
Owner

SamStudio8 commented Oct 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants