-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Alfred 4 or newer #24
Add support for Alfred 4 or newer #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LitoMore, thanks for the PR!
Just upgrading the package doesn't work, because it now returns an object instead of a string. For example, this line should be changed to something like this.
const getWorkflowDir = () => resolveAlfredPrefs().then(prefs => path.join(prefs.path, 'workflows'));
Same goes for the other resolveAlfredPrefs()
calls
Thanks! Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going through all the files and noticed that the unlink
functionality is probably broken as well because it's hardcoded for Alfred 3. Not sure what the paths are for Alfred 4 and above?
https://github.com/SamVerschueren/alfred-link/blob/master/lib/unlink.js#L17-L22
|
@kouchao Thank you. I think we should only unlink the version returns by the |
@SamVerschueren Updated. I also added a section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's coming together :). Last comments that needs to be resolved and I believe that should be it 👌
Awesome! Thank you very much @LitoMore! 🎉 |
@SamVerschueren You are welcome. Next step I am going to create a pull request on Alfy. |
No need, semver catches this because I released it as patch. Tested it locally and works perfectly fine for me. Had to do a quick fix here though SamVerschueren/resolve-alfred-prefs@2072c5b. Suddenly your user home path came up in my terminal 😂 |
Good point.
OK, let me create a PR to fix this bug. |
Resolves #23