Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for session token based credentials #57

Closed
wants to merge 1 commit into from

Conversation

humblelistener
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Aug 31, 2017

Coverage Status

Coverage remained the same at 98.783% when pulling 70751c7 on humblelistener:patch-1 into b6671cf on SamVerschueren:master.

Copy link
Owner

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good change! Can you rebase against master? I changed something in the Options interface at line 9.

You should also add sessionToken?: string to that interface.

Also, in the readme, under the Connect header, add the following block at the bottom of that section.

Or provide a sessionToken if you want to use temporary credentials.

db.connect({
   accessKeyId: 'accessKeyId',
   region: 'us-west-1'
});

@SamVerschueren
Copy link
Owner

Ping @humblelistener :)

@SamVerschueren
Copy link
Owner

Fixed in 4fa3797

@humblelistener humblelistener deleted the patch-1 branch February 9, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants