Feature/support any number versions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this package Sam. We have been using it during the last months and everything was right.
In the last days we have discovered a weak in the package. If the versions associated with a lambda are more than 50 (the default number of versions returned by
AWS.Lambda.listVersionsByFunction), and the lib has to calculate the last version number, this calculation can be wrong, because it doesn't get every version (just the first 50 ones).I've modified the lib, making recursive calls when needed, to get every lambda version from AWS. Moreover, I've updated the tests to make them compatible with the installed version of ava, and I've added a test for the new feature.
I hope this PR could me merge in your library :-)