Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Docker Compose Configuration by Using .env File #79

Open
jayanth-kumar-morem opened this issue Jun 19, 2023 · 4 comments
Open

Secure Docker Compose Configuration by Using .env File #79

jayanth-kumar-morem opened this issue Jun 19, 2023 · 4 comments
Assignees
Labels

Comments

@jayanth-kumar-morem
Copy link
Collaborator

Currently, our Docker Compose configuration contains sensitive information such as the PostgreSQL username and password. This information is directly written in the docker-compose.yml file, which is not a secure practice and could lead to accidental exposure of these details.

To enhance the security of our setup, we should move these sensitive details to a separate .env.sample file. Docker Compose automatically reads from a .env.sample file in the same directory as the docker-compose.yml file, if it exists.

Tasks:

  1. Create a .env.sample file in the same directory as the docker-compose.yml file.
  2. Move the POSTGRES_USER and POSTGRES_PASSWORD environment variables from the docker-compose.yml file to the .env.sample file.
  3. Update the docker-compose.yml file to reference these variables from the .env.sample file.
  4. Update the documentation to instruct users to create their own .env.sample file with their specific details.

Acceptance Criteria:

  1. The docker-compose.yml file no longer contains the POSTGRES_USER and POSTGRES_PASSWORD environment variables directly.
  2. The .env.sample file is created and contains the POSTGRES_USER and POSTGRES_PASSWORD environment variables.
@PrathameshTheurkar
Copy link

hi @jayanth-kumar-morem can you assign this task to me I would like to contribute to this .

@PrathameshTheurkar
Copy link

Pull request #104:

@PrathameshTheurkar
Copy link

@jayanth-kumar-morem can u plz check my Pull request #104 and kindly merge it .

@singhalkarun
Copy link
Collaborator

@PiyushRaj927 to pick this.

  • Add a sample.env and accept POSTGRES_USERNAME and POSTGRES_PASSWORD
  • Image Tag can be accepted from env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants