Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Registry #20

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Added Registry #20

merged 1 commit into from
Apr 7, 2024

Conversation

Savio629
Copy link
Collaborator

@Savio629 Savio629 commented Apr 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@Savio629
Copy link
Collaborator Author

Savio629 commented Apr 3, 2024

image

Generating .stencil file and then showing to the user

Any changes in the console log?

// @sooraj1002 @techsavvyash

@techsavvyash
Copy link
Member

The log looks good, but why is showing an error in the last line of the console?

@sooraj1002 sooraj1002 changed the base branch from master to dev April 3, 2024 13:05
@Savio629 Savio629 changed the title Registry Added Registry Apr 3, 2024
@Savio629
Copy link
Collaborator Author

Savio629 commented Apr 3, 2024

if we come out of the stencil project, .stencil is not found so throwing .stencil not found error
also as there can be a lot of projects so running stencil ls inside project folder to avoid duplicates is necessary

@techsavvyash
Copy link
Member

Is the PR done? @Savio629

@Savio629
Copy link
Collaborator Author

Savio629 commented Apr 7, 2024

Does this output look fine?
#20 (comment)

@techsavvyash
Copy link
Member

The output looks fine for the first iteration, how does the .stencil file look?

@Savio629
Copy link
Collaborator Author

Savio629 commented Apr 7, 2024

The contents of .stencil file looks same as the stencil ls output

@sooraj1002
Copy link
Collaborator

Looks good

@sooraj1002 sooraj1002 merged commit ce5dadf into SamagraX-Stencil:dev Apr 7, 2024
@techsavvyash techsavvyash linked an issue Apr 9, 2024 that may be closed by this pull request
1 task
@Savio629 Savio629 deleted the registry branch May 4, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli] Registry for cli
3 participants