Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixe for access_token expiration problem. #19

Closed
wants to merge 2 commits into from
Closed

Fixe for access_token expiration problem. #19

wants to merge 2 commits into from

Conversation

jdsingh
Copy link

@jdsingh jdsingh commented Jan 31, 2015

fixes #17

Fix issue with extend() and default value of expires_at

Changed setExpiresAtFromTimeStamp() because facebook is sending seconds to expire in response rather than TimeStamp

and Facebook introduced never expiring tokens and 1 year age would be enough for those tokens.

Jagdeep Singh added 2 commits January 31, 2015 18:27
fixes #17

Fix issue with extend() and default value of access token
Fixed for access_token expiration problem.
@SammyK
Copy link
Owner

SammyK commented Feb 2, 2015

Thanks for the PR @jagdeepsinghmundi!

  1. Make sure the tests still pass after making changes. This PR has failing tests in it.
  2. Check out the fix I made on official PHP SDK that addresses this issue. The PR needs to accommodate both expires_at and expires return values.

@jdsingh
Copy link
Author

jdsingh commented Feb 2, 2015

Sorry I broke the test.

I was running phpunit on old branch and thought it passed.

And thanks for fix.

@SammyK
Copy link
Owner

SammyK commented Feb 2, 2015

No worries! If you just port over the fix and make sure the tests pass I'll merge it in. :)

@jdsingh jdsingh closed this Jul 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants