Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow pairing JSON scan in existing wallet #354

Open
antonio-fr opened this issue Aug 8, 2019 · 0 comments
Open

Disallow pairing JSON scan in existing wallet #354

antonio-fr opened this issue Aug 8, 2019 · 0 comments

Comments

@antonio-fr
Copy link

Since adding a specific Dojo server on a initialized wallet is not possible, the QRscanner in an existing wallet (top icon) should not validate a valid paring JSON string.
When scanning a pairing JSON (from the Dojo admin), the app opens the Networking panel and adds a Dojo line. There's only an unrelated error message when click on Enable.
The scanner in the wallet should display an error immediately, eventually in the payment transaction panel, as it is wit an invalid QR code.
I recommend to filter the data read by the scanner, only quit automatically the scanner to perform some actions, on specific "known" patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant