Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EML scanner enchancement #525

Merged
merged 5 commits into from
Mar 12, 2024
Merged

EML scanner enchancement #525

merged 5 commits into from
Mar 12, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Mar 12, 2024

Description

Please include a summary of the change and which is fixed.

  • Add deep attachement scan in EML
  • fix mypy issues
  • Documentation update
  • Benchmark scores update

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.52%. Comparing base (2efea3f) to head (cf91934).
Report is 2 commits behind head on main.

Files Patch % Lines
credsweeper/deep_scanner/eml_scanner.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   90.53%   90.52%   -0.01%     
==========================================
  Files         127      127              
  Lines        4394     4400       +6     
  Branches      707      708       +1     
==========================================
+ Hits         3978     3983       +5     
- Misses        274      275       +1     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek changed the title Documentation update EML scanner enchancement Mar 12, 2024
@babenek babenek marked this pull request as ready for review March 12, 2024 13:05
@babenek babenek requested a review from a team as a code owner March 12, 2024 13:05
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@babenek babenek merged commit bb2a30d into Samsung:main Mar 12, 2024
30 checks passed
@babenek babenek deleted the documentation branch March 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants