ML refactoring #551
Merged
ML refactoring #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touch a file to rerun bm
babenek
requested review from
xDizzix,
Yullia,
iuriimet,
meanrin,
Dmitriy-NK,
csh519 and
kmnls
csh519
reviewed
May 27, 2024
experiment/src/data_loader.py
Outdated
Comment on lines
166
to
199
| # line_index_set.add((index[0], index[1])) | ||
| # rules_set.update(line_data["RuleName"]) | ||
| # if not reference_line_data: | ||
| # reference_line_data = copy.deepcopy(line_data) | ||
|
|
||
| # remove to reduce memory usage | ||
| # line_data.pop("line_num") | ||
| # line_data.pop("path") | ||
| # line_data.pop("value_end") | ||
|
|
||
| values.append(line_data) | ||
| # values = list(detected_data.values()) | ||
|
|
||
| # for _, i in meta_data.items(): | ||
| # if i["Used"] is True: | ||
| # continue | ||
| # elif i["GroundTruth"] == 'T' \ | ||
| # and any(x in rules_set for x in i["Category"].split(':')) \ | ||
| # and (i["FilePath"], i["LineStart"]) in line_index_set \ | ||
| # and 0 <= i["ValueStart"] < i["ValueEnd"]: | ||
| # print(f"NOT FOUND:{i}") | ||
| # markup_data = { | ||
| # "line": None, # read | ||
| # "line_num": i["LineStart"], # not used | ||
| # "path": i["FilePath"], | ||
| # "value": None, | ||
| # "value_start": i["ValueStart"], # remove | ||
| # "value_end": i["ValueEnd"], # remove | ||
| # "variable": None, # ??? | ||
| # 'RuleName': (x for x in i["Category"].split(':') if x in line_index_set), | ||
| # 'GroundTruth': 'T', | ||
| # 'ext': Util.get_extension(i["FilePath"]), | ||
| # 'type': i["FilePath"].split('/')[-2] | ||
| # } | ||
| # assert markup_data.keys() == reference_line_data.keys(), reference_line_data.keys() |
There was a problem hiding this comment.
It seems old code left.. Please remove if you don't need it.
| @@ -798,7 +798,6 @@ def test_param_n(self) -> None: | |||
| def test_param_p(self) -> None: | |||
| # internal parametrized tests for quick debug | |||
| items = [ # | |||
| ("prod.py", b"secret_api_key='Ah\\tga%$FiQ@Ei8'", "secret_api_key", "Ah\\tga%$FiQ@Ei8"), # | |||
There was a problem hiding this comment.
It seems this PR makes some FPs...
Why those cases are removed?
There was a problem hiding this comment.
\t sign did not appear in train set, so the sequence gives low ml probability. I'll update the sample instead removing
csh519
reviewed
May 28, 2024
Co-authored-by: ShinHyung Choi <sh519.choi@samsung.com>
csh519
approved these changes
May 28, 2024
xDizzix
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.