Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update github->action javadoc permissions #313

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

tdrozdovsky
Copy link
Collaborator

Description

fix permissions for github->action

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

  • CI system update

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdrozdovsky please add top level permissions

Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@o-kopysov o-kopysov added github_actions Pull requests that update GitHub Actions code fix labels Nov 16, 2023
@o-kopysov
Copy link
Collaborator

Fix for security issue.

@o-kopysov o-kopysov merged commit 927c018 into Samsung:main Nov 16, 2023
7 checks passed
@tdrozdovsky tdrozdovsky deleted the fix-permission branch November 19, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants