Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Javadoc comments for config, exception, repository and unit #315

Merged
merged 2 commits into from
Nov 20, 2023
Merged

docs: Add Javadoc comments for config, exception, repository and unit #315

merged 2 commits into from
Nov 20, 2023

Conversation

o-kopysov
Copy link
Collaborator

Description

This PR is related to #307 and covers config, exception, repository and unit packages.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

@o-kopysov
docs: Add Javadoc comments for config, exception, repository and unit
03c57c0 
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added the documentation Improvements or additions to documentation label Nov 17, 2023
@o-kopysov o-kopysov self-assigned this Nov 17, 2023
@o-kopysov
fix: Add missing license and copyright statements
78537e3 
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
o-konoval
o-konoval approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov mentioned this pull request Nov 18, 2023
Closed
6 tasks
tiokim
tiokim approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit b8ba406 into Samsung:main Nov 20, 2023
7 checks passed
@o-kopysov o-kopysov deleted the jd-extend branch November 20, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiokim tiokim tiokim approved these changes

@tdrozdovsky tdrozdovsky tdrozdovsky approved these changes

@o-konoval o-konoval o-konoval approved these changes

@v-kerimov v-kerimov Awaiting requested review from v-kerimov

@m-rudyk m-rudyk Awaiting requested review from m-rudyk

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees

@o-kopysov o-kopysov

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@o-kopysov @tiokim @tdrozdovsky @o-konoval