-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add throw Exception
in case of error in LPVSWebhookUtil
class
#384
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
============================================
- Coverage 91.54% 90.97% -0.58%
+ Complexity 495 493 -2
============================================
Files 48 48
Lines 1703 1706 +3
Branches 206 206
============================================
- Hits 1559 1552 -7
- Misses 86 97 +11
+ Partials 58 57 -1 ☔ View full report in Codecov by Sentry. |
JaCoCo Test Coverage Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that some lines of code from catch
like this link should be updated in terms of IllegalArgumentException
too. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Samsung#384) * fix: Add throw Exception in case of error for LPVSWebhookUtil class Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update catch code to process IllegalArgumentException Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Samsung#384) * fix: Add throw Exception in case of error for LPVSWebhookUtil class Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update catch code to process IllegalArgumentException Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Samsung#384) * fix: Add throw Exception in case of error for LPVSWebhookUtil class Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update catch code to process IllegalArgumentException Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Samsung#384) * fix: Add throw Exception in case of error for LPVSWebhookUtil class Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update catch code to process IllegalArgumentException Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Pull Request
Description
Current pull request provides correct processing of exceptions in
LPVSWebhookUtil
class.Also, it contains corresponding updates in unit tests.
Fixes #301
Type of change
Please delete options that are not relevant.
Checklist: