Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch from Spring 2.7 to 3.2 #400

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

rnd4you
Copy link
Contributor

@rnd4you rnd4you commented Jan 10, 2024

Pull Request

Description

Spring 2.7 has been replaced with 3.2.

Fixes #351

Type of change

  • Code cleanup/refactoring - replace Spring version numbers and javax -> jakarta in several files
  • Documentation update - README.md English changed

Testing

All previous tests that used to work with Spring 2.7 are operating well with Spring 3.2 as well.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c511a34) 90.90% compared to head (8f16b66) 90.90%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #400   +/-   ##
=========================================
  Coverage     90.90%   90.90%           
  Complexity      486      486           
=========================================
  Files            47       47           
  Lines          1737     1737           
  Branches        209      209           
=========================================
  Hits           1579     1579           
  Misses           94       94           
  Partials         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@userai-dev userai-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested variant of deploy "Build and Run LPVS from Source Code" on basic scenarios- no issues:
2024-01-10T16:15:09.638+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 1
2024-01-10T16:15:09.686+02:00 INFO 45584 --- [ LPVS-ASYNC::1] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:16:25.162+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 2
2024-01-10T16:16:25.165+02:00 INFO 45584 --- [ LPVS-ASYNC::2] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:17:39.253+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 3
2024-01-10T16:17:39.255+02:00 INFO 45584 --- [ LPVS-ASYNC::3] com.lpvs.service.LPVSQueueService : GitHub queue processing...

2024-01-10T16:18:58.722+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 4
2024-01-10T16:18:58.733+02:00 INFO 45584 --- [ LPVS-ASYNC::4] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:19:48.424+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 5
2024-01-10T16:19:48.426+02:00 INFO 45584 --- [ LPVS-ASYNC::5] com.lpvs.service.LPVSQueueService : GitHub queue processing...
2024-01-10T16:20:56.730+02:00 INFO 45584 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 6
2024-01-10T16:20:56.731+02:00 INFO 45584 --- [ LPVS-ASYNC::6] com.lpvs.service.LPVSQueueService : GitHub queue processing...

Needed additional tests with Docker scenarios- when it will be ready.

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment- variant of deploy "Build and Run LPVS from Source Code" on basic scenarios- no issues.
Needed additional tests with Docker scenarios- when it will be ready.
Approved.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Docker scenario tested - working properly.
Approved.

@o-kopysov o-kopysov added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jan 10, 2024
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: rnd4you <rnd4u.org@gmail.com>
@o-kopysov o-kopysov merged commit bdbb46a into Samsung:main Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Spring Boot to v3.2.x
8 participants