Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Sync source code with external modules #420

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR includes changes caused by code sync with the internal module.
After completion of the internal test, a new tag, v1.4.1, will be assigned.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added the enhancement New feature or request label Feb 5, 2024
@o-kopysov o-kopysov added this to the v1.4.1 milestone Feb 5, 2024
@o-kopysov o-kopysov self-assigned this Feb 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e5ccdf) 90.90% compared to head (e9ce25e) 90.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #420      +/-   ##
============================================
+ Coverage     90.90%   90.93%   +0.03%     
- Complexity      486      489       +3     
============================================
  Files            47       47              
  Lines          1737     1743       +6     
  Branches        209      210       +1     
============================================
+ Hits           1579     1585       +6     
  Misses           94       94              
  Partials         64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 117755a into main Feb 5, 2024
9 checks passed
@o-kopysov o-kopysov deleted the ext-submodule branch February 5, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants