Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPQEditor] Make layout more user-friendly #1541

Open
stamalakhov opened this issue Apr 28, 2023 · 6 comments
Open

[MPQEditor] Make layout more user-friendly #1541

stamalakhov opened this issue Apr 28, 2023 · 6 comments

Comments

@stamalakhov
Copy link
Contributor

What?

Let's make MPQEditor layout more user- friendly.

Why?

See original discussion in #1539 (comment).

@stamalakhov
Copy link
Contributor Author

stamalakhov commented Apr 28, 2023

@dayo09 @seanshpark
Initial draft is proposed at #1542.
Otherwise we can try to make both sections collapsible as was done at metadataviewer .
Or/and we can add ? button for both sections.

@dayo09
Copy link
Contributor

dayo09 commented May 1, 2023

+ @jinevening

For other reviewers, to summarize:
I suggested adding 'default configuration' or 'per-layer configuration' title to each area as below.

          Hi, this is another UI feedback.

It's not related to this PR, but rather related to the draft #1505.

image

It seems that : In the (1) area, it decides the default quantization configuration and (2) area specifies the per-node(layer) quantization configuration.

At first look, I didn't understand what the (1) area would do. From my point of view, I propose to add 'Set default quantization' 'Set specific layer's quantization' in each areas.

Originally posted by @dayo09 in #1539 (comment)

@dayo09
Copy link
Contributor

dayo09 commented May 2, 2023

I just got another idea - how about adding 'default' just as the same as the other layers? Not as a radio button, but just as a drop box element just the same as other layers. Therefore we don't need to put some text information.

@stamalakhov
Copy link
Contributor Author

stamalakhov commented May 2, 2023

I just got another idea - how about adding 'default' just as the same as the other layers? Not as a radio button, but just as a drop box element just the same as other layers. Therefore we don't need to put some text information.

@dayo09

  1. Like this?:
    235097735-1036982d-4a60-4b7a-97f9-ff75ae4b250a

  2. or ?:
    235097735-1036982d-4a60-4b7a-97f9-ff75ae4b250a (1)

  3. Or something different?

@dayo09
Copy link
Contributor

dayo09 commented May 2, 2023

I meant 1.) 😄

@stamalakhov
Copy link
Contributor Author

I meant 1.) 😄

Ahh. Ok. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants